Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python requires 3.5+ #26

Merged
merged 2 commits into from
Oct 28, 2017
Merged

Python requires 3.5+ #26

merged 2 commits into from
Oct 28, 2017

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Oct 28, 2017

Fixes #25.

@ofek
Copy link
Owner

ofek commented Oct 28, 2017

Thanks! Unknown kwargs have no effect right? So this would still work for pip<9.0.0?

@hugovk
Copy link
Collaborator Author

hugovk commented Oct 28, 2017

I'm not sure about unknown kwargs.

I believe it'll have no effect for pip<9.0.0, so perhaps this at the top of setup.py and/or one of the pypinfo/ files should do it.

import sys
if sys.version_info < (3, 5):
    sys.exit('pypinfo requires Python 3.5+')

There's a bigger thing on PLOS/allofplos#20 but perhaps something simpler is fine.

@ofek ofek merged commit 750b3e1 into ofek:master Oct 28, 2017
@hugovk hugovk deleted the python_requires branch October 28, 2017 20:30
suv27 pushed a commit to suv27/pypinfo that referenced this pull request Oct 5, 2019
REestwick pushed a commit to REestwick/pypinfo that referenced this pull request Apr 1, 2024
* Python requires 3.5+

* Update setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants